Skip to content

BlockTools issue #20185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

BlockTools issue #20185

merged 1 commit into from
Oct 22, 2025

Conversation

@arvidn
Copy link
Contributor

@arvidn arvidn commented Oct 22, 2025

  • fix BlockTools where transaction_generator is not None was incorrectly used as a proxy for whether the block was a TX block or not.
  • improve error messages for plot size mismatches
  • update the minimum plot size for v2 plots on testnet11 (which, surprisingly, also affects our simulations in CI)

@arvidn arvidn added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests labels Oct 22, 2025
@arvidn
fix issue in BlockTools where transaction_generator was (incorrectly)…
58a1b82 
… used as a proxy for whether the block was a TX block or not. Also improve error messages for plot sizes as well as the minimum plot size for v2 plots on testnet (which also affects our simulations in CI)
@arvidn arvidn force-pushed the block-tools-prev-tx-block branch from 00b82aa to 58a1b82 Compare October 22, 2025 08:40
@arvidn arvidn requested a review from almogdepaz October 22, 2025 08:53
@arvidn arvidn marked this pull request as ready for review October 22, 2025 08:53
@arvidn arvidn requested a review from a team as a code owner October 22, 2025 08:53
@arvidn arvidn requested a review from wjblanke October 22, 2025 09:06
wjblanke
wjblanke approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@coveralls-official
Copy link

coveralls-official bot commented Oct 22, 2025

Pull Request Test Coverage Report for Build 18710463496

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 18 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.004%) to 90.846%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node.py 1 87.13%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/wallet/util/wallet_sync_utils.py 1 85.57%
chia/data_layer/data_layer.py 2 85.73%
chia/farmer/farmer_api.py 2 95.01%
chia/simulator/setup_services.py 3 96.24%
chia/wallet/wallet_node.py 7 86.39%
Totals Coverage Status
Change from base Build 18700200565: -0.004%
Covered Lines: 102343
Relevant Lines: 112496
💛 - Coveralls

@pmaslana pmaslana merged commit 85e935e into main Oct 22, 2025
653 of 662 checks passed
@pmaslana pmaslana deleted the block-tools-prev-tx-block branch October 22, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjblanke wjblanke wjblanke approved these changes

@almogdepaz almogdepaz almogdepaz approved these changes

Assignees

No one assigned

Labels

Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arvidn @wjblanke @almogdepaz @pmaslana